cmake: drop HAVE_C_FLAG_Wno_long_double logic for ancient Apple gcc
#16513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5feabee307ce22dfa052b5bf7a21d7394a107e55.
It was added as part of the initial CMake commit in curl via 4c5307b (2009-04-02). Suppressing a stray `-Wlong-double` warning in `mprintf.c`. This was before Apple switched to clang, and likely affected the Apple distributed GCC, version 4.2.1 at the time. It applied the workaround to CMake builds only, though the issue seems build-tool agnostic. Yet, it was not suppressed or reported for autotools builds. For these reasons this logic seems obsolete and this patch drops it with no replacement. In sub-commits I added (and reverted) in-source suppression. In case it becomes necessary, that should fix it for all build tools.
vszakats
added
build
cmake
tidy-up
appleOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial curl CMake commit introduced it in 2009-04-02 via
4c5307b. Suppressing a stray
-Wlong-doublewarning inmprintf.c. This was before Apple switchedto clang, and likely affected the Apple distributed GCC, version 4.2.1
at the time. It applied the workaround to CMake builds only, though
the issue seems build-tool agnostic. Yet, it was not suppressed or
reported for autotools builds.
For these reasons this logic seems obsolete and this patch drops it with
no replacement. It saves a feature detection for GCC builds for macOS.
In PR sub-commits I added (and reverted) in-source suppression. In case
it becomes necessary, that should fix it for all build tools.