lib: replace while(ISBLANK()) loops with Curl_str_passblanks() #16520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/str-passblanks
branch
2 times, most recently
from
bc9f9bf to
0f47ebd
Compare
bagder
added a commit
that referenced
this pull request
Feb 28, 2025
bagder
force-pushed
the
bagder/str-passblanks
branch
from
0f47ebd to
7ddcfaf
Compare
bagder
added a commit
that referenced
this pull request
Mar 1, 2025
bagder
force-pushed
the
bagder/str-passblanks
branch
from
cf71ecc to
8572070
Compare
- replace several ISSPACE() with ISBLANK(), since the former also skips CR and LF which in most cases should not occur where this macro is used - after this commit, there is no ISSPACE() user left in libcurl code, but unfortunately tool and test code use the macro so it cannot be removed. Closes #16520
bagder
force-pushed
the
bagder/str-passblanks
branch
from
8572070 to
11de23c
Compare
bagder
changed the title
rouault
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace several ISSPACE() with ISBLANK(), since the former also skips
CR and LF which in most cases should not occur where this macro is
used
after this commit, there is no ISSPACE() user left in libcurl code, but
unfortunately tool and test code use the macro so it cannot be removed.