[http2]: enhance error messages on Curl_dyn* upon receiving headers #16536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Mar 2, 2025
starrify
force-pushed
the
h2-max-http-header-error-handling-16535
branch
from
ed04b5d to
ab23825
Compare
|
Thanks a lot! I've updated the branch (to 5743423) to reflect the suggested changes. |
This is a partial fix of curl#16535. The error message format is borrowed from the existing code[1]. Sample message before: curl: (56) process_pending_input: nghttp2_session_mem_recv() returned -902:The user callback function failed Sample message after: curl: (56) Error receiving HTTP2 header: 100(A value or data field grew larger than allowed) [1]: https://github.com/curl/curl/blob/df672695e5992ad9b99819e9950de682e243cb48/lib/http2.c#L1999-L2000
starrify
force-pushed
the
h2-max-http-header-error-handling-16535
branch
from
ab23825 to
5743423
Compare
icing
approved these changes
Mar 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix of #16535. The error message format is borrowed from the existing code1.
Sample message before:
curl: (56) process_pending_input: nghttp2_session_mem_recv() returned -902:The user callback function failed
Sample message after:
curl: (56) Failed receiving HTTP2 header: 100(A value or data field grew larger than allowed)