http2: reset stream on response header error #16544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't that the way it's supposed to be? The RFC says the GOAWAY applies to streams above the stream identifier used in the GOAWAY. |
refs curl#16535 We send a GOAWAY, but some servers ignore that and happily continue sending the stream response. RST the stream when response header errors are encountered.
When the server sends HEADER/CONTINUATION frames that exceed nghttp2's size, this error is being reported via the on_invalid_frame_recv callback. Without registering there, it will go unnoticed. RST the stream when such a frame is encountered.
Yes, indeed. Nginx seems to disagree. Am about to add some more in our implementation in this PR to cope with this. |
nghttp2 will on its own send GOAWAY frames, closing the connection, when internal processing of frames runs into errors. This may not become visible in a direct error code from a call to nghttp2. Check for session being closed on ingress processing (on sending, we already did that) and report an error if so. In addition, monitor outgoing GOAWAY not initiated by us so that the user will get a fail message when that happens. Add some more long response header tests.
icing
force-pushed
the
h2-reset-on-header-err
branch
from
ff28c1e to
819733b
Compare
bagder
pushed a commit
that referenced
this pull request
Mar 5, 2025
When the server sends HEADER/CONTINUATION frames that exceed nghttp2's size, this error is being reported via the on_invalid_frame_recv callback. Without registering there, it will go unnoticed. RST the stream when such a frame is encountered. Closes #16544
bagder
pushed a commit
that referenced
this pull request
Mar 5, 2025
nghttp2 will on its own send GOAWAY frames, closing the connection, when internal processing of frames runs into errors. This may not become visible in a direct error code from a call to nghttp2. Check for session being closed on ingress processing (on sending, we already did that) and report an error if so. In addition, monitor outgoing GOAWAY not initiated by us so that the user will get a fail message when that happens. Add some more long response header tests. Closes #16544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #16535
We send a GOAWAY, but some servers ignore that and happily continue sending the stream response. RST the stream when response header errors are encountered.