Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnutls, setting priority via --ciphers #16557

Closed
wants to merge 6 commits into from
Closed

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 4, 2025

No longer ignore the --ciphers argument in gnutls curl builds, but use it to set the gnutls priority string.

When the set ciphers start with '+', '-' or '!', it is appended to the curl generated priority string. Otherwise it replaces the curl one completely.

Add test_17_18 to check various combinations.

Added documentation.

@github-actions github-actions bot added the tests label Mar 4, 2025
@icing icing added TLS and removed tests labels Mar 4, 2025
@github-actions github-actions bot added the tests label Mar 4, 2025
@bagder
Copy link
Member

bagder commented Mar 4, 2025

I think this feels like the most sensible approach. I approve.

icing added 3 commits March 5, 2025 11:02
No longer ignore the `--ciphers` argument in gnutls curl builds, but
use it to set the gnutls priority string.

When the set ciphers start with '+', '-' or '!', it is *appended* to the
curl generated priority string. Otherwise it replaces the curl one
completely.

Add test_17_18 to check various combinations.
@github-actions github-actions bot added the CI Continuous Integration label Mar 5, 2025
@icing icing requested a review from bagder March 5, 2025 10:51
@bagder bagder closed this in 9bfa64f Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tests TLS
Development

Successfully merging this pull request may close these issues.

2 participants