tool_getparam: avoid strdup on platforms not doing UTF8 conversions #16560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
reviewed
Mar 4, 2025
bagder
force-pushed
the
bagder/parse-nodupe
branch
from
a004810 to
532d020
Compare
bagder
added a commit
that referenced
this pull request
Mar 4, 2025
... and use more const strings. Closes #16560
bagder
force-pushed
the
bagder/parse-nodupe
branch
from
8f6fb16 to
b57d395
Compare
bagder
added a commit
that referenced
this pull request
Mar 4, 2025
... and use more const strings. Closes #16560
bagder
force-pushed
the
bagder/parse-nodupe
branch
from
b57d395 to
1e7244a
Compare
bagder
force-pushed
the
bagder/parse-nodupe
branch
from
1e7244a to
e051985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is all except Windows UNICODE builds.
Which required a switch to more const strings.