Fix pkcs11 uri checking for key files. #16591
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this issue when trying to use the new PKCS#11 provider support in curl.
I was getting the following error when trying to use a pkcs11 uri as a key, in curl 8.12.1:
After checking the code that prints the error, I have found out that it is incorrectly checking if cert_file is a pkcs11 uri, instead of checking key_file:
https://github.com/curl/curl/blob/curl-8_12_1/lib/vtls/openssl.c#L1678
Probably a copy-paste error.