-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test1022: Add support for rc releases #16626
Conversation
Fix the following test failure: curl-config: illegal value
Analysis of PR #16626 at 87d563a1: Test 564 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 713 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 715 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
Logs:
These tests are not related to this PR. |
Hm, is there no EDIT: Ah, there's a job called |
There is a distcheck job in CI but it operates on git sources, not tarballs.
|
OK, so not the same thing ;) i.e. autotools EDIT: #12088 (comment) |
We do that exact discheck in CI. That's not the problem. The problem was that we never did a |
Thanks! |
It's not the same check if it doesn't use the same version as whatever the tag is (it uses |
What is your point? |
If a tag was made for the RC and it used the tag value if existed, it'd catch this? Right now, it uses a fixed version, so if there's something subtle like this test, it's not going to notice. |
If we updated the test so that it would test the scenario that it didn't work for, then it would have caught this problem. Yes, that seems correct. We welcome all help and assistance we can get in improving our test suite. |
Fix the following test failure:
curl-config: illegal value
Note: The rc relase tarball is currently named with the
-rc
suffix but the--version
parameter reports it as-rc1
.Usually, the lack of a number implies that
-rc
is equivalent to-rc0
.This does not cause any issues today, but I recommend matching these numbers for the next releases (and to assume
rc
==rc0
).