Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/server: sync wait_ms() with the libcurl implementation #16627

Closed
wants to merge 6 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Mar 8, 2025

It contains a series of bugfixes and updates applied to libcurl's
Curl_wait_ms() over the years, but missed from the copy in
tests/server/util.c:

It fixes wait_ms() to check for, and return SOCKERRNO. Fixing error
handling on Windows.

Also:

@vszakats vszakats added tests Windows Windows-specific labels Mar 8, 2025
@vszakats vszakats changed the title tests/server: fix wait_ms() to work on SOCKERRNO tests/server: sync wait_ms() with the libcurl implementation Mar 8, 2025
@bagder
Copy link
Member

bagder commented Mar 9, 2025

You can simplify this a lot more by just not caring about why wait_ms() fails if it does...

@vszakats vszakats closed this in 5681628 Mar 9, 2025
@vszakats
Copy link
Member Author

vszakats commented Mar 9, 2025

Ah, just merged. I guess we could simplify, but my next step would be to drop this dupe a re-use Curl_wait_ms(). Then continue with cleanups there. The fail reason also seems unimportant there, though for select.c code it may be used upper in the call chain.

@vszakats vszakats deleted the util-wait-sockerrno branch March 9, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants