curl: add my_setopt_long() and _offt() #16669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new dedicated functions for setting long and curl_off_t options with curl_easy_setopt(). These make it easier to make sure we pass on the right option (types) so that the --libcurl code also gets right.
This comment was marked as resolved.
This comment was marked as resolved.
MarcelRaad
reviewed
Mar 12, 2025
| struct OperationConfig *config = per->config; /* for the macro below */ | ||
| #ifdef CURL_DISABLE_LIBCURL_OPTION | ||
| (void)config; | ||
| (void)global; |
There was a problem hiding this comment.
This leads to an unused parameter warning with CURL_DISABLE_LIBCURL_OPTION because the my_setopt macros don't use global in this case:
https://curl.se/dev/log.cgi?id=20250312061525-3878059#prob1
There was a problem hiding this comment.
I'm on it.
That would also indicate we could use a new CI job...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new dedicated functions for setting long and curl_off_t options with curl_easy_setopt(). These make it easier to make sure we pass on the right option (types) so that the --libcurl code also gets right.