build: do not apply curl debug macros to tests/server by default
#16705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also syncs passing these macros with CMake builds. Before this patch, autotools passed them via `curl_config.h`. After this patch it passed on the command-line, like in CMake builds.
vszakats
force-pushed
the
dis-debug-for-servers
branch
from
17d0363 to
d219e3c
Compare
1 task
vszakats
added a commit
that referenced
this pull request
Mar 14, 2025
Before this patch, autotools builds excluded TrackMemory sources (`lib/memdebug.c` and `lib/curl_multibyte.c`) based on the `DEBUGBUILD` setting. This works in most cases because its value is the same as `CURLDEBUG` by default, but the correct condition is `CURLDEBUG`. It should fix `--disable-debug --enable-curldebug --enable-unity` builds. (not tested in CI) It also syncs behavior with cmake builds. Ref: #16705 Closes #16723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unnecessary and possibly unexpected to build test servers with
debug-enabled features and memory tracking whenever the tested curl is
built like that (which is a requirement for some tests, so curl is
mostly built like that when running tests.) It also makes building
servers a little bit faster with cmake for the most common cases.
You can apply debug options to
tests/serverwith these new options:./configure:--enable-server-debug.-DENABLE_SERVER_DEBUG.Also sync the way we pass these macros in autotools, with CMake builds.
Before this patch, autotools passed them via
curl_config.h. After thispatch it passes them on the command-line, like cmake builds do.
This patch also make these option no longer passed to examples and
http/clientin cmake builds, where they were no-ops anyway.Ref: #15000
--disable-debug --enable-curldebug --enable-unity buildsfix to a separate PR and rebase that onto this. → autotools: useCURLDEBUGto exclude TrackMemory code from unity #16723