Skip to content

tests/server: drop unused base64.pl #16713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Mar 14, 2025

When committed in 2004, it served as a developer helper tool while
coreutils was yet missing a base64 command.

Assisted-by: Dan Fandrich

@vszakats vszakats marked this pull request as draft March 14, 2025 00:40
@vszakats vszakats changed the title tests: test if base64.pl is required [TEST] tests: test if base64.pl is required Mar 14, 2025
@github-actions github-actions bot added the tests label Mar 14, 2025
@vszakats vszakats changed the title [TEST] tests: test if base64.pl is required [TEST] tests: test if base64.pl is required Mar 14, 2025
@dfandrich
Copy link
Contributor

base64.pl was first checked in in 2004, while coreutils didn't get the base64 command until 2006. I suspect it was there just for developer convenience.

@vszakats
Copy link
Member Author

Ah, okay, it explains why no apparent reference in the code.
I suspect, this is safe to delete now?

@vszakats vszakats changed the title [TEST] tests: test if base64.pl is required [?] tests/server: drop unused base64.pl Mar 14, 2025
@vszakats vszakats changed the title [?] tests/server: drop unused base64.pl tests/server: drop unused base64.pl Mar 14, 2025
@vszakats vszakats marked this pull request as ready for review March 14, 2025 02:06
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the base64 command these days, and even better, we have %b64 support in test cases so ideally we should not do new tests with base64 in them.

It is totally fine to remove this old leftover helper tool.

@vszakats vszakats closed this in 63cf464 Mar 14, 2025
@vszakats vszakats deleted the base64pl branch March 14, 2025 09:01
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
When committed in 2004, it served as a developer helper tool while
`coreutils` was yet missing a `base64` command.

Assisted-by: Dan Fandrich
Closes curl#16713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants