tests/server: give global path variable a more descriptive name
#16719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename a global variable in server code to avoid colliding with its name
used elsewhere in libcurl. This isn't causing an issue at this time, but
makes the code sensitive to compile order, and may cause `-Wshadow`
warnings if the global declaration precedes libcurl code:
```
lib/curl_multibyte.c:317:34: error: declaration of 'path' shadows a global declaration [-Werror=shadow]
317 | int curlx_win32_stat(const char *path, struct_stat *buffer)
| ~~~~~~~~~~~~^~~~
In file included from tests/server/resolve.c:47,
from bld/tests/server/server_bundle.c:7,
from bld/tests/server/CMakeFiles/servers.dir/Unity/unity_0_c.c:4:
tests/server/util.h:64:20: note: shadowed declaration is here
64 | extern const char *path; /* where to find the 'data' dir */
| ^~~~
```
Affecting these CI jobs:
```
AppVeyor / CMake, VS2022, Release, x64, Schannel, Shared, Unicode, DEBUGBUILD, no-CURLDEBUG, Build-tests
Windows / linux-mingw, CM gcc
Windows / mingw, CM i686 schannel R
Windows / mingw, CM ucrt-x86_64 schannel uwp
Windows / msvc, CM x64-windows boringssl
```
https://github.com/curl/curl/actions/runs/13845123447/job/38741731971?pr=15000
https://ci.appveyor.com/project/curlorg/curl/builds/51693340
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Use a more descriptive global variable name in server code, also to avoid colliding with this name used elsewhere in libcurl. This isn't causing an issue at this time, but makes the code prone to `-Wshadow` warnings in unity mode, if the global variable is compiled first. This specific variable could collide with the `path` argument of the `curlx_win32_stat()` function. Closes curl#16719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more descriptive global variable name in server code, also
to avoid colliding with this name used elsewhere in libcurl.
This isn't causing an issue at this time, but makes the code prone
to
-Wshadowwarnings in unity mode, if the global variable iscompiled first. This specific variable could collide with the
pathargument of the
curlx_win32_stat()function.Seen in these CI jobs while doing tests:
https://github.com/curl/curl/actions/runs/13845123447/job/38741731971?pr=15000
https://ci.appveyor.com/project/curlorg/curl/builds/51693340