curl_setup: always define WIN32_LEAN_AND_MEAN on Windows#1672
Merged
Conversation
|
Coverage remained the same at 0.0% when pulling 75421532aec9273e985a90b30baf5436d7b9b666 on MarcelRaad:win32_lean_and_mean into a5834e5 on curl:master. |
Member
|
Working in VS2010 project, winbuild and also passing appveyor CI so let's see what happens |
MarcelRaad
force-pushed
the
win32_lean_and_mean
branch
from
7542153 to
beb0848
Compare
Member
Author
|
Thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to always define WIN32_LEAN_AND_MEAN before including any
Windows headers to avoid pulling in unnecessary headers. This avoids
unnecessary macro clashes and compiler warnings.
Ref: #1562
Supersedes #1668 and part of #1667.