Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_setup: always define WIN32_LEAN_AND_MEAN on Windows #1672

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@MarcelRaad
Copy link
Member

commented Jul 10, 2017

Make sure to always define WIN32_LEAN_AND_MEAN before including any
Windows headers to avoid pulling in unnecessary headers. This avoids
unnecessary macro clashes and compiler warnings.

Ref: #1562

Supersedes #1668 and part of #1667.

@coveralls

This comment has been minimized.

Copy link

commented Jul 10, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling 7542153 on MarcelRaad:win32_lean_and_mean into a5834e5 on curl:master.

@jay

This comment has been minimized.

Copy link
Member

commented Jul 11, 2017

Working in VS2010 project, winbuild and also passing appveyor CI so let's see what happens

curl_setup: always define WIN32_LEAN_AND_MEAN on Windows
Make sure to always define WIN32_LEAN_AND_MEAN before including any
Windows headers to avoid pulling in unnecessary headers. This avoids
unnecessary macro clashes and compiler warnings.

Ref: #1562
Closes #1672

@MarcelRaad MarcelRaad force-pushed the MarcelRaad:win32_lean_and_mean branch from 7542153 to beb0848 Jul 11, 2017

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2017

Coverage Status

Coverage increased (+0.03%) to 75.986% when pulling beb0848 on MarcelRaad:win32_lean_and_mean into c5e87fd on curl:master.

@MarcelRaad MarcelRaad merged commit beb0848 into curl:master Jul 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 75.986%
Details

@MarcelRaad MarcelRaad deleted the MarcelRaad:win32_lean_and_mean branch Jul 11, 2017

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2017

Thanks for testing!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.