autotools: use CURLDEBUG to exclude TrackMemory code from unity
#16723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
CURLDEBUG (not DEBUGBUILD) to exclude memdebug code from unityCURLDEBUG to exclude memdebug code from unity
vszakats
changed the title
CURLDEBUG to exclude memdebug code from unityCURLDEBUG to exclude TrackMemory code from unity
1 task
vszakats
changed the title
CURLDEBUG to exclude TrackMemory code from unityCURLDEBUG to exclude TrackMemory code from unity
17 tasks
To sync with cmake. This should fix `--disable-debug --enable-curldebug --enable-unity` builds. (not tested in CI)
vszakats
force-pushed
the
am-multibyte-memdebug-unity
branch
from
8bb5bce to
b3f32f3
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Before this patch, autotools builds excluded TrackMemory sources (`lib/memdebug.c` and `lib/curl_multibyte.c`) based on the `DEBUGBUILD` setting. This works in most cases because its value is the same as `CURLDEBUG` by default, but the correct condition is `CURLDEBUG`. It should fix `--disable-debug --enable-curldebug --enable-unity` builds. (not tested in CI) It also syncs behavior with cmake builds. Ref: curl#16705 Closes curl#16723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, autotools builds excluded TrackMemory sources
(
lib/memdebug.candlib/curl_multibyte.c) based on theDEBUGBUILDsetting. This works in most cases because its value is the same as
CURLDEBUGby default, but the correct condition isCURLDEBUG.It should fix
--disable-debug --enable-curldebug --enable-unitybuilds. (not tested in CI)
It also syncs behavior with cmake builds.
Ref: #16705
tests/serverby default #16705