-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
curl_multibyte: fixup low-level calls, include in unity builds #16742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/curl_multibyte.c
into unitylib/curl_multibyte.c
into unity
lib/curl_multibyte.c
into unity
The comment at the head of this file should be updated to explain why all functions in the file must now call the original versions of memory functions. For example,. /*
* The functions in this file are curlx functions which are not tracked by the
* curl memory tracker memdebug so they do not use the macro replacements
* free, malloc, etc. Instead wrap the names in parentheses to call the
* original versions: `ptr = (malloc)(123)`, `(free)(ptr)`, etc.
*/ |
That comment could use an update indeed. I also learned about test 1132, I guess the root reason we don't want to call the debug allocators from these Updated the comment! |
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
This reverts commit a5cd709.
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
Also adjust
()
around low-level calls preventing macro overrides viae.g.
memdebug.h
:malloc
andfree
._open
. (We do not override_open
in curl.)Tidy-up: also sync libcurlu custom macro order in cmake with autotools.
Follow-up to f42a279 #11928