websocket: add option to disable auto-pong reply #16744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
vszakats
reviewed
Mar 17, 2025
|
Does anything remain to do, to move this PR forward? |
|
@viscruocco the PR itself looks fine - now we only need to wait for the feature window to open again to allow new features such as this to get merged (for 8.14.0). The feature window for 8.13.0 closed a few weeks ago. You can prepare for this to make sure the PR speaks of the correct version for this feature. The feature window is planned to open again on April 12. |
bagder
changed the title
viscruocco
commented
Mar 25, 2025
viscruocco
commented
Apr 9, 2025
viscruocco
force-pushed
the
no-auto-pong
branch
from
08583c0 to
3390d40
Compare
viscruocco
commented
Apr 14, 2025
This adds another bitflag on CURLOPT_WS_OPTIONS (CURLWS_NOAUTOPONG) that disables the default and automatic PONG reply in the WebSocket layer. Authored-by: brimonk on github
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
viscruocco
force-pushed
the
no-auto-pong
branch
from
3390d40 to
0d298e0
Compare
bagder
approved these changes
Apr 18, 2025
|
Thanks, both of you! |
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
This adds another bitflag on CURLOPT_WS_OPTIONS (CURLWS_NOAUTOPONG) that disables the default and automatic PONG reply in the WebSocket layer. Assisted-by: Calvin Ruocco Closes curl#16744
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
This adds another bitflag on CURLOPT_WS_OPTIONS (CURLWS_NOAUTOPONG) that disables the default and automatic PONG reply in the WebSocket layer. Assisted-by: Calvin Ruocco Closes curl#16744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #12220 with kind permission of @brimonk.
Additionally added some more documentation and explicitly initialized CURLOPT_WS_OPTIONS values to their defaults.