cmake: Replace exec_program() with execute_process() #16779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exec_program() is deprecated as of CMake 3.0. This also removes the rm_out variable as it isn't used in the output. In execute_process() the ERROR_QUIET and OUTPUT_QUIET resemble the behavior of exec_program(OUTPUT_VARIABLE) behavior in this case.
This comment was marked as outdated.
This comment was marked as outdated.
vszakats
approved these changes
Mar 21, 2025
|
Thanks @petk! |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The `exec_program()` is deprecated as of CMake 3.0. This also removes the `rm_out` variable as it isn't used in the output. In `execute_process()` the `ERROR_QUIET` and `OUTPUT_QUIET` resemble the behavior of `exec_program(OUTPUT_VARIABLE)` behavior in this case. Closes curl#16779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exec_program()is deprecated as of CMake 3.0.This also removes the
rm_outvariable as it isn't used in the output. Inexecute_process()theERROR_QUIETandOUTPUT_QUIETresemble the behavior ofexec_program(OUTPUT_VARIABLE)behavior in this case.