libssh2: fix to ignore known_hosts if SHA256 host public key is set
#16805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 23, 2025
Syncing behavior with MD5 host public keys. libcurl implemented to force a host key type when the host is present in `known_hosts`, and disabled this logic when an MD5 host public key is explicitly set. libcurl later received support for SHA256 host public keys. This update missed to extend the `known_hosts` logic with the new key type. This caused test 3022 to fail if a pre-existing `known_hosts` listed the test server IP (127.0.0.1) with a non-RSA host key algo. Follow-up to d1e7d91 curl#7646 Follow-up to 272282a curl#4747 Closes curl#16805
vszakats
changed the title
known_hosts when SHA256 host public key is setknown_hosts if SHA256 host public key is set
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 24, 2025
Syncing behavior with MD5 host public keys. libcurl implemented to force a host key type when the host is present in `known_hosts`, and disabled this logic when an MD5 host public key is explicitly set. libcurl later received support for SHA256 host public keys. This update missed to extend the `known_hosts` logic with the new key type. This caused test 3022 to fail if a pre-existing `known_hosts` listed the test server IP (127.0.0.1) with a non-RSA host key algo. Follow-up to d1e7d91 curl#7646 Follow-up to 272282a curl#4747 Closes curl#16805
bagder
approved these changes
Mar 24, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Syncing behavior with MD5 host public keys. libcurl implemented to force a host key type for hosts is present in `known_hosts`, and disabled this logic when an MD5 host public key is explicitly set. libcurl later received support for SHA256 host public keys. This update missed to extend the `known_hosts` logic with the new key type. This caused test 3022 to fail if a pre-existing `known_hosts` listed the test server IP (127.0.0.1) with a non-RSA host key algo. Follow-up to d1e7d91 curl#7646 Follow-up to 272282a curl#4747 Closes curl#16805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing behavior with MD5 host public keys.
libcurl implemented to force a host key type for hosts is present in
known_hosts, and disabled this logic when an MD5 host public key isexplicitly set. libcurl later received support for SHA256 host public
keys. This update missed to extend the
known_hostslogic with the newkey type.
This caused test 3022 to fail if a pre-existing
known_hostslistedthe test server IP (127.0.0.1) with a non-RSA host key algo.
Follow-up to d1e7d91 #7646
Follow-up to 272282a #4747