tests: remove base64 encoded sections #16816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #16816 at 2093758f: Test 445 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
bagder
force-pushed
the
bagder/test262-nobase64
branch
from
2093758 to
54d97c4
Compare
The base64 sections were added in a time when there was no other way to do these tests. Now we remove them again to make less "hidden" data in the test suite. For several test cases we instead then provide a sequence of binary octets which is not really better, but I have tried to minimize them.
bagder
force-pushed
the
bagder/test262-nobase64
branch
from
54d97c4 to
3d0cf53
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The base64 sections were added in a time when there was no other way to do these tests. Now we remove them again to make less "hidden" data in the test suite. For several test cases we instead then provide a sequence of binary octets which is not really better, but I have tried to minimize them. Closes curl#16816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since base64 can be used to hide content (xz style), avoid it when possible
This is a test shot. There are more tests to clean.