test615: fix for Cygwin, unignore in CI #16818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---d---em-- OK (600 out of 1740, remaining: 02:09, took 0.946s, duration: 01:07) test 0613 SKIPPED: # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- test 0615 SKIPPED: # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- test 0614 SKIPPED: # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- # file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r-- test 0612...[SFTP post-quote remove file] https://github.com/curl/curl/actions/runs/14024607711/job/39261169320?pr=16803
```
chmod 0444, "rofile.txt";
if($^O eq 'cygwin') {
# file: rofile.txt # owner: runneradmin # group: None user::r-- group::--- group:SYSTEM:rwx #effective:r-- group:Administrators:rwx #effective:r-- group:Users:rwx #effective:r-- mask::r-- other::r--
system "/bin/setfacl --remove-all rofile.txt";
# file: rofile.txt # owner: runneradmin # group: None user::r-- group::--- other::r--
chmod 0444, "rofile.txt";
# file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r--
system "/bin/setfacl ---default --modify u:r,g:r,o:r rofile.txt";
# file: rofile.txt # owner: runneradmin # group: None user::r-- group::r-- other::r--
}
```
vszakats
changed the title
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Setting a server-side file read-only by `chmod 0444` has does not
prevent overwriting it via SFTP upload (as tested in CI).
Fix it by setting its MS-DOS read-only attribute in addition. It
requires the Cygwin tool `chattr`.
Also unignore in CI.
Fixes:
```
test 0615...[SFTP put remote failure]
curl returned 0, when expecting 9
615: exit FAILED
=== Start of file stderr615
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 30 0 0 100 30 0 93 --:--:-- --:--:-- --:--:-- 95
100 30 0 0 100 30 0 92 --:--:-- --:--:-- --:--:-- 92
=== End of file stderr615
```
Ref: https://github.com/curl/curl/actions/runs/14037991918/job/39300723214#step:12:1269
Closes curl#16818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a server-side file read-only by
chmod 0444has does notprevent overwriting it via SFTP upload (as tested in CI).
Fix it by setting its MS-DOS read-only attribute in addition. It
requires the Cygwin tool
chattr.Also unignore in CI.
Fixes:
Ref: https://github.com/curl/curl/actions/runs/14037991918/job/39300723214#step:12:1269