rustls: update to 0.15, add SSLKEYLOGFILE, client certs, ECH, platform verifier #16828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describes using a package manager or pre-built binaries and adopts the 0.15 installation from source instructions. Previously the rustls docs described installing rustls-ffi from source using the GNU Makefile. The upstream project has switched to using cargo-c as a cross-platform solution that works well with the rust toolchain, pkg-config, and Windows and so this needs an update. Similarly, for folks that want to avoid the extra cargo-c tool requirement, rustls-ffi provides binary releases for common platforms, and some Linux distributions/package managers offer pre-built packages. The install instructions are expanded to cover these options since they're generally better for end users than building the dep. from source (no `rustc` required).
Take the latest rustls-ffi version and install it via the upstream project's `.deb` for x86_64 linux.
This allows TLS implementations to use the constants for defining sizes and verification.
With rustls-ffi 0.15+ we can set up a callback for writing TLS secrets hooked up to call Curl_tls_keylog_write. To make sure the associated file is cleaned up we update the Curl_ssl struct for the rustls-ffi vtls backend to have a cleanup callback.
e.g. `curl --tlsv1.3 --ech grease ...`
e.g. `curl --tlsv1.3 --ech ecl:<BASE64 encoded ECH config list> ...`
E.g. `curl --tlsv1.3 --doh-url https://one.one.one.one/dns-query --ech true ...`
e.g. `curl --ca-native ...`
cpu
commented
Mar 25, 2025
bagder
approved these changes
Mar 27, 2025
bagder
pushed a commit
that referenced
this pull request
Mar 27, 2025
e.g. `curl --tlsv1.3 --ech ecl:<BASE64 encoded ECH config list> ...` Closes #16828
bagder
pushed a commit
that referenced
this pull request
Mar 27, 2025
E.g. `curl --tlsv1.3 --doh-url https://one.one.one.one/dns-query --ech true ...` Closes #16828
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi folks,
This PR updates the
rustls-ffivTLS backend to use the ✨ literally brand-new ✨ rustls-ffi 0.15 release.Beyond updating
rustls-ffi/rustlsthis branch brings:.debfor installation.I've done this commit-by-commit to aid reviewability, and to preserve the authorship of @yedayak for the commits they contributed that I modified.
Continues from #16796
Replaces #16827
Replaces #15803