cmake: add shell completion support #16833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cm-sh-completion
branch
from
ca0bde1 to
ab1281d
Compare
cm: fix install dir fallbacks cm: fix long lines
vszakats
force-pushed
the
cm-sh-completion
branch
from
ab1281d to
ad83f61
Compare
``` CMake Error at bld/scripts/cmake_install.cmake:46 (file): file INSTALL cannot find "/home/runner/work/curl/curl/scripts/curl.fish": No such file or directory. Call Stack (most recent call first): bld/cmake_install.cmake:52 (include) ``` https://github.com/curl/curl/actions/runs/14086112584/job/39450558258?pr=16833#step:38:528
vszakats
force-pushed
the
cm-sh-completion
branch
from
e4f96cb to
beedc54
Compare
vszakats
force-pushed
the
cm-sh-completion
branch
from
beedc54 to
f9d1d5f
Compare
Seems overkill (and somewhat slow).
|
Proposing this for the upcoming release. Being disabled by default, it's unlikely to cause harm. It also |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 18, 2025
Also: - tidy up the if tree. - drop `include(GNUInstallDirs)` in favor of the upper-level one. Reported-by: Daniel Engberg Bug: curl#16946 (comment) Follow-up to c8b0f0c curl#16833
vszakats
added a commit
that referenced
this pull request
Apr 18, 2025
Also: - tidy up the `if` tree. - drop `include(GNUInstallDirs)` in favor of the upper-level one. Reported-by: Daniel Engberg Bug: #16946 (comment) Follow-up to c8b0f0c #16833 Closes #17094
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 23, 2025
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Also: - tidy up the `if` tree. - drop `include(GNUInstallDirs)` in favor of the upper-level one. Reported-by: Daniel Engberg Bug: curl#16946 (comment) Follow-up to c8b0f0c curl#16833 Closes curl#17094
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Follow-up to c8b0f0c curl#16833 Closes curl#17147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the last (*) missing bit for feature parity with autotools.
Also test in CI. Add a new
cmake installstep to GHA/macos.(*) AFAIK. Let us know if there's something else missing.