test313: disable CRL test for Schannel due to lack of support and flakiness #16862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source code and documentation suggests that CRL is not supported by curl's Schannel TLS backend. It's frequently flaky in CI with both MinGW and MSVC jobs, e.g.: https://github.com/curl/curl/actions/runs/14134841988/job/39603994164?pr=16858 It also has a high failure rate according to Test Clutch: https://testclutch.curl.se/static/reports/results-count.html Disable this test for the Schannel backend. --- Question is why it pass test 313 at all?
vszakats
changed the title
bagder
approved these changes
Mar 29, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 29, 2025
Follow-up to 8adee88 curl#16862 Follow-up to 8b1b5cd curl#16660 Ref: curl#16677
vszakats
added a commit
that referenced
this pull request
Mar 30, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…kiness The source code and documentation says that CRL is not supported by curl's Schannel TLS backend. It's also frequently flaky in CI with both MinGW and MSVC jobs, e.g.: https://github.com/curl/curl/actions/runs/14134841988/job/39603994164 (Schannel) https://github.com/curl/curl/actions/runs/14134841988/job/39606336445 (Schannel) https://github.com/curl/curl/actions/runs/13981383629/job/39147183706 (LibreSSL) ``` curl returned 35, when expecting 60 ``` This test was passing with Schannel because it misses the `--insecure` option and thus always returns 60, regardless of passing `--crlfile` or not: ``` curl: (60) schannel: CertGetCertificateChain trust error CERT_TRUST_REVOCATION_STATUS_UNKNOWN More details here: https://curl.se/docs/sslcerts.html curl failed to verify the legitimacy of the server and therefore could not establish a secure connection to it. To learn more about this situation and how to fix it, please visit the webpage mentioned above. ``` Closes curl#16862
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Instead of via `tests/data/DISABLED` file. They are all missing CRL feature support, as opposed to being broken. Follow-up to 8adee88 curl#16862 Follow-up to 8b1b5cd curl#16660 Closes curl#16865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code and documentation says that CRL is not supported by
curl's Schannel TLS backend.
It's also frequently flaky in CI with both MinGW and MSVC jobs, e.g.:
https://github.com/curl/curl/actions/runs/14134841988/job/39603994164 (Schannel)
https://github.com/curl/curl/actions/runs/14134841988/job/39606336445 (Schannel)
https://github.com/curl/curl/actions/runs/13981383629/job/39147183706 (LibreSSL)
This test was passing with Schannel because it misses the
--insecureoption and thus always returns 60, regardless of passing
--crlfileornot: