test: turn unittest 1308 into libtest #16891
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Hm, it was because of |
| return TEST_ERR_FAILURE; \ | ||
| } \ | ||
| } while(0) | ||
| #include "curlcheck.h" |
There was a problem hiding this comment.
Would it be "cleaner" to move curlcheck.h to tests/libtest?
The variable unitfail that it's using, is declared there already.
It may avoid the two way dependency between units and libtests.
There was a problem hiding this comment.
Would it be "cleaner" to move curlcheck.h to tests/libtest?
It is used by just about every unit test and this the first change making use of it in libtests. It seemed to belong there more than in libtests...
There was a problem hiding this comment.
That's true, but it doesn't work without the global var in libtests/first.c and libtests/test.h.
It's somewhat confusing. Maybe that would be better be moved inside units and use a local macro here.
There was a problem hiding this comment.
Hm. unitfail also sort of implies a unit test by name. Maybe we should just move them up a level and use them freely in both unit tests and libtests. I think we can do that outside of this PR to keep this focused.
Test 1308 was wrongly marked a unit test when in reality it is a libtest. Converted to test 3033.
bagder
force-pushed
the
bagder/libtest-unit
branch
from
af388f9 to
33d0f16
Compare
bagder
changed the title
Test 1308 was wrongly marked a unit test when in reality it is a libtest.