Test client authentication, add https-mtls server #16923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #16923 at de80d163: Test 417 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 65 different CI jobs (the link just goes to one of them). Test 2088 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 83 different CI jobs (the link just goes to one of them). Test 1194 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2202 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
reviewed
Apr 2, 2025
vszakats
reviewed
Apr 2, 2025
|
It seems test 417 fails because when stunnel has the CAfile, it sends it in the chain to the client, which is not required. This means test 417 gets two certificates which the test doesn't expect. |
bagder
reviewed
Apr 3, 2025
yedayak
force-pushed
the
test-client-auth
branch
3 times, most recently
from
baf858d to
f9f243e
Compare
yedayak
added a commit
to yedayak/curl
that referenced
this pull request
Apr 3, 2025
SIZE_MAX is an very overkill size for certificates or keys, lower it to 100KiB for both certificate and keys. The default max size of openssl is 100KiB for the entire chain [1], and it seems firefox fails at ~60kb [2]. Found by curl#16923 [0] https://docs.openssl.org/3.2/man3/SSL_CTX_set_max_cert_list/#notes [2] https://0x00.cl/blog/2024/exploring-tls-certs/
|
Well this seems to have already found a failure in rustls, opened #16951 |
yedayak
added a commit
to yedayak/curl
that referenced
this pull request
Apr 3, 2025
SIZE_MAX is an very overkill size for certificates or keys, lower it to 100KiB for both certificate and keys. The default max size of openssl is 100KiB for the entire chain [1], and it seems firefox fails at ~60kb [2]. Found by curl#16923 [0] https://docs.openssl.org/3.2/man3/SSL_CTX_set_max_cert_list/#notes [2] https://0x00.cl/blog/2024/exploring-tls-certs/
yedayak
added a commit
to yedayak/curl
that referenced
this pull request
Apr 3, 2025
SIZE_MAX is an very overkill size for certificates or keys, lower it to 100KiB for both certificate and keys. The default max size of openssl is 100KiB for the entire chain [1], and it seems firefox fails at ~60kb [2]. Found by curl#16923 [0] https://docs.openssl.org/3.2/man3/SSL_CTX_set_max_cert_list/#notes [2] https://0x00.cl/blog/2024/exploring-tls-certs/
bagder
pushed a commit
that referenced
this pull request
Apr 3, 2025
SIZE_MAX is an very overkill size for certificates or keys, lower it to 100KiB for both certificate and keys. The default max size of openssl is 100KiB for the entire chain [1], and it seems firefox fails at ~60kb [2]. Found by #16923 [0] https://docs.openssl.org/3.2/man3/SSL_CTX_set_max_cert_list/#notes [2] https://0x00.cl/blog/2024/exploring-tls-certs/ Closes #16951
yedayak
force-pushed
the
test-client-auth
branch
from
f9f243e to
5bac069
Compare
vszakats
reviewed
Apr 3, 2025
It wasn't used, and didn't do anything since the folder it got didn't have files with names of the hash of the subjects. [1] [1] https://www.stunnel.org/static/stunnel.html#CApath-CA_DIRECTORY
This adds a new certificate to generate which has the clientAuth key usage enabled, and uses it to connect to a https-mtls server.
yedayak
force-pushed
the
test-client-auth
branch
from
5bac069 to
880322b
Compare
bagder
approved these changes
Apr 7, 2025
bagder
pushed a commit
that referenced
this pull request
Apr 7, 2025
- test2088 verifies that mutual tls works This adds a new certificate to generate which has the clientAuth key usage enabled, and uses it to connect to a https-mtls server. Closes #16923
|
Thanks! |
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
It wasn't used, and didn't do anything since the folder it got didn't have files with names of the hash of the subjects. [1] [1] https://www.stunnel.org/static/stunnel.html#CApath-CA_DIRECTORY Closes curl#16923
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
- test2088 verifies that mutual tls works This adds a new certificate to generate which has the clientAuth key usage enabled, and uses it to connect to a https-mtls server. Closes curl#16923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test using mutual TLS (mtls), this adds a new server type,
https-mtls, which turns on theverifyChainin stunnel, which forces client to authenticate using a certificate signed by the CA specified byCAfile.Also generate a client certificate to use when authenticating.
In addition, this removes the
CApathconfig since it requires CA files being named with the hash of the subject [1], which isn't done here (if I understand correctly it didn't even point to the certs/ directory).[1] https://www.stunnel.org/static/stunnel.html#CApath-CA_DIRECTORY
Refs #16804 #16686