genserv.pl: fail with a message if openssl is missing or failing
#16929
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: W. Fixes curl#16926
|
Looks similar to #16928 😄 |
|
Yep :) I was a bit late, took your |
vszakats
changed the title
openssl is missing or failing
vszakats
changed the title
openssl is missing or failingopenssl is missing or failing
jay
reviewed
Apr 2, 2025
It's not supposed to fail with any tool called `openssl` AFAIK. (But I did not check all possible variants) I meant this to catch BoringSSL which is NOT supporting this command, but that's silly because BoringSSL's tool is called `bssl`, so it won't be called at all in the first place.
jay
added a commit
to jay/curl
that referenced
this pull request
Apr 3, 2025
- Use File::Spec->devnull() to get the null device path. Prior to this change we used NUL for Windows and /dev/null otherwise. Bug: curl#16929 (comment) Reported-by: Viktor Szakats Closes #xxxx
jay
added a commit
to jay/curl
that referenced
this pull request
Apr 3, 2025
- Use File::Spec->devnull() to get the null device path. Prior to this change we used NUL for Windows native perl and /dev/null otherwise. Bug: curl#16929 (comment) Reported-by: Viktor Szakats
jay
added a commit
to jay/curl
that referenced
this pull request
Apr 3, 2025
- Use File::Spec->devnull() to get the null device path. Prior to this change we used NUL for Windows native perl and /dev/null otherwise. Bug: curl#16929 (comment) Reported-by: Viktor Szakats Closes #xxxx
|
@graywolf Attribution question: What name would you prefer to attribute you in the commit message? |
|
|
Thanks @graywolf! |
jay
added a commit
that referenced
this pull request
Apr 4, 2025
- Use File::Spec->devnull() to get the null device path. Prior to this change we used NUL for Windows native perl and /dev/null otherwise. Bug: #16929 (comment) Reported-by: Viktor Szakats Closes #16930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: Tomas Volf
Fixes #16926
Follow-up to 44341e7 #16824
Ref: #16928
Co-authored-by: Daniel Stenberg