New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeval: introduce curlval as a struct timeval replacement #1693

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Jul 21, 2017

... to make all libcurl internals able to use the same data types for
the struct members. The timeval struct differs subtly on several
platforms so it makes it cumbersome to use everywhere.

Ref: #1652

timeval: introduce curlval as a struct timeval replacement
... to make all libcurl internals able to use the same data types for
the struct members. The timeval struct differs subtly on several
platforms so it makes it cumbersome to use everywhere.

Ref: #1652
@coveralls

This comment has been minimized.

coveralls commented Jul 21, 2017

Coverage Status

Coverage decreased (-75.3%) to 0.0% when pulling 4c5b3ff on bagder/timeval-curlval into 42a4cd4 on master.

@coveralls

This comment has been minimized.

coveralls commented Jul 21, 2017

Coverage Status

Coverage decreased (-49.2%) to 26.069% when pulling 0540b34 on bagder/timeval-curlval into 42a4cd4 on master.

@@ -48,7 +48,7 @@ struct timeval curlx_tvnow(void)

This comment has been minimized.

@jay

jay Jul 25, 2017

Member

I agree this is the right move. What do you think about a name like curltime instead of curlval to know it's time related? The (long)s above need to be changed to time_t and unsigned, otherwise looks fine

This comment has been minimized.

@jay

jay Jul 25, 2017

Member

Changes I needed to get it working in Visual Studio are at bagder/timeval-curlval...jay:pr_1693_amended

jay added a commit to jay/curl that referenced this pull request Jul 25, 2017

squashme: more changes for curlval transition
- Revert some curlval changes in select.c since select uses timeval.

- Various typecasts elsewhere.

Ref: curl#1693
@bagder

This comment has been minimized.

Member

bagder commented Jul 26, 2017

Renamed the struct to 'curltime', merged @jay's changes (manually).

I plan to merge these commits squashed once the CI agrees they're fine.

@coveralls

This comment has been minimized.

coveralls commented Jul 28, 2017

Coverage Status

Coverage increased (+0.03%) to 75.308% when pulling a9a8fa4 on bagder/timeval-curlval into 42a4cd4 on master.

@bagder bagder closed this in 4dee50b Jul 28, 2017

@bagder bagder deleted the bagder/timeval-curlval branch Jul 28, 2017

jay added a commit that referenced this pull request Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment