timeval: introduce curlval as a struct timeval replacement #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make all libcurl internals able to use the same data types for the struct members. The timeval struct differs subtly on several platforms so it makes it cumbersome to use everywhere. Ref: #1652
jay
reviewed
Jul 25, 2017
|
|
||
| return now; | ||
| } | ||
|
|
There was a problem hiding this comment.
I agree this is the right move. What do you think about a name like curltime instead of curlval to know it's time related? The (long)s above need to be changed to time_t and unsigned, otherwise looks fine
There was a problem hiding this comment.
Changes I needed to get it working in Visual Studio are at bagder/timeval-curlval...jay:pr_1693_amended
|
Renamed the struct to 'curltime', merged @jay's changes (manually). I plan to merge these commits squashed once the CI agrees they're fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make all libcurl internals able to use the same data types for
the struct members. The timeval struct differs subtly on several
platforms so it makes it cumbersome to use everywhere.
Ref: #1652