make: clean tests better #16986
Closed
make: clean tests better #16986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 'make clean' in the root dir now also invokes 'make clean' in the tests subdir so that it cleans up better recursively. The Makefile.am does not list 'tests' as a normal subdir to avoid building that directory for a normal make invoke. 2. 'make clean' in the tests/libtest and tests/unit directories now *explicitly* remove the unity build executables even if this is not a unit build. This, because those files may be leftovers from previous builds and such leftovers can otherwise linger around and since 'runtests.pl' dynamically acts differently based on the mere *presence* of those files, they can keep you fooled for a while until you realize...
vszakats
approved these changes
Apr 6, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 14, 2025
Sync clean target with other test bundles. Follow-up to d3761bb curl#16986
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
1. 'make clean' in the root dir now also invokes 'make clean' in the tests subdir so that it cleans up better recursively. The Makefile.am does not list 'tests' as a normal subdir to avoid building that directory for a normal make invoke. 2. 'make clean' in the tests/libtest and tests/unit directories now *explicitly* remove the unity build executables even if this is not a unit build. This, because those files may be leftovers from previous builds and such leftovers can otherwise linger around and since 'runtests.pl' dynamically acts differently based on the mere *presence* of those files, they can keep you fooled for a while until you realize... Closes curl#16986
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Sync clean target with other test bundles. Follow-up to d3761bb curl#16986 Closes curl#17053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'make clean' in the root dir now also invokes 'make clean' in the tests subdir so that it cleans up better recursively. The Makefile.am does not list 'tests' as a normal subdir to avoid building that directory for a normal make invoke.
'make clean' in the tests/libtest and tests/unit directories now explicitly remove the unity build executables even if this is not a unit build. This, because those files may be leftovers from previous builds and such leftovers can otherwise linger around and since 'runtests.pl' dynamically acts differently based on the mere presence of those files, they can keep you fooled for a while until you realize...