cmake: use INCLUDE_DIRECTORIES prop to specify local header dirs
#16993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cm-dirprop-more
branch
from
65cfb9a to
a1df146
Compare
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To use more modern cmake, and make it somewhat more obvious where these header directories should apply. Also move setting the directory property _before_ defining targets, to make them inherit this directory property. Ref: https://cmake.org/cmake/help/latest/command/include_directories.html Ref: https://cmake.org/cmake/help/latest/prop_dir/INCLUDE_DIRECTORIES.html Follow-up to 45f7cb7 curl#16238 Closes curl#16993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use more modern cmake, and make it somewhat more obvious where these
header directories should apply.
Also move setting the directory property before defining targets,
to make them inherit this directory property.
Ref: https://cmake.org/cmake/help/latest/command/include_directories.html
Ref: https://cmake.org/cmake/help/latest/prop_dir/INCLUDE_DIRECTORIES.html
Follow-up to 45f7cb7 #16238