runtests: remove server verification after start #17005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we start on our own port we know the server running is us. By removing unnecessary verification we speed up tests a little.
|
Analysis of PR #17005 at 75603ebc: Test 1265 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1324 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2086 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 1117 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
added a commit
that referenced
this pull request
Apr 10, 2025
And also require HTTP. Also add `IPv6` to the keywords. Fixing: Linux AM openssl !ipv6 !--libcurl: ``` FAIL 1265: 'NO_PROXY with IPv6 numerical address' HTTP, HTTP proxy, http_proxy, NO_PROXY, noproxy FAIL 1324: 'HTTP with --resolve and [ipv6address]' HTTP, HTTP GET, --resolve FAIL 2086: 'Pre-request callback for HTTP IPv6' HTTP, IPv6 ``` Ref: https://github.com/curl/curl/actions/runs/14378524385/job/40318328714?pr=17012#step:41:3789 Follow-up to a09e491 #17005 Closes #17014
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Since we start the server on our own port we know the server running is us. By removing unnecessary verification we speed up tests a little. Closes curl#17005
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
And also require HTTP. Also add `IPv6` to the keywords. Fixing: Linux AM openssl !ipv6 !--libcurl: ``` FAIL 1265: 'NO_PROXY with IPv6 numerical address' HTTP, HTTP proxy, http_proxy, NO_PROXY, noproxy FAIL 1324: 'HTTP with --resolve and [ipv6address]' HTTP, HTTP GET, --resolve FAIL 2086: 'Pre-request callback for HTTP IPv6' HTTP, IPv6 ``` Ref: https://github.com/curl/curl/actions/runs/14378524385/job/40318328714?pr=17012#step:41:3789 Follow-up to a09e491 curl#17005 Closes curl#17014
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Since we start the server on our own port we know the server running is us. By removing unnecessary verification we speed up tests a little. Closes curl#17005
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
And also require HTTP. Also add `IPv6` to the keywords. Fixing: Linux AM openssl !ipv6 !--libcurl: ``` FAIL 1265: 'NO_PROXY with IPv6 numerical address' HTTP, HTTP proxy, http_proxy, NO_PROXY, noproxy FAIL 1324: 'HTTP with --resolve and [ipv6address]' HTTP, HTTP GET, --resolve FAIL 2086: 'Pre-request callback for HTTP IPv6' HTTP, IPv6 ``` Ref: https://github.com/curl/curl/actions/runs/14378524385/job/40318328714?pr=17012#step:41:3789 Follow-up to a09e491 curl#17005 Closes curl#17014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we start on our own port we know the server running is us. By removing unnecessary verification we speed up tests a little.