Skip to content

docs: add missing return statement in examples #17024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pkropachev
Copy link
Contributor

Add missing return statement in CURLMOPT_TIMERDATA.md and CURLMOPT_TIMERFUNCTION.md.

It's crucial return a value from the timer callback. A value can be set in register by another call and then taken from the same register as return value for timer callback. All in-progress transfers will be aborted in this curl_multi if -1 is returned.

@pkropachev pkropachev force-pushed the fix-missing-return-state branch from 04b9578 to af46095 Compare April 11, 2025 11:14
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I need to check why this was not caught by the CI job...

@bagder bagder closed this in d9a86b6 Apr 11, 2025
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants