ngtcp2+openssl support #17027
Closed
ngtcp2+openssl support #17027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @tatsuhiro-t who did the heavy lifting in ngtcp2 🎉 |
|
Make sure that curl does either:
|
Happily, we already did the SSL frees before the nghttp3_conn_del() and ngtcp2_conn_del() calls. |
vszakats
reviewed
Apr 11, 2025
|
CMake support attempt here: #17018 (passes CI, but not tested with an actual ngtcp2 + openssl build) |
icing
force-pushed
the
ossl-quic2
branch
2 times, most recently
from
673a822 to
66dd9b2
Compare
With the new addition of QUIC support and the support in ngtcp2 main branch, make the necessary adjustments in curl to support this combination. - add support in configure.ac to detect the feature OPENSSL_QUIC_API2 in openssl - initialise ngtcp2 properly in this combination - add a Curl_vquic_init() for global initialisation that ngtcp2 likes for performance reasons - add documentation on how to build in docs/HTTP3.md - add CI testing in http3-linux.yml
vszakats
added a commit
that referenced
this pull request
Apr 16, 2025
``` curl 8.13.1-DEV (Darwin) libcurl/8.13.1-DEV OpenSSL/3.5.0 [...] ngtcp2/1.12.90 nghttp3/1.9.0 Release-Date: [unreleased] Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets zstd ``` Ref: #17027 Closes #17018
vszakats
approved these changes
Apr 16, 2025
2 tasks
vszakats
added a commit
that referenced
this pull request
Apr 24, 2025
- update text on dependency feature detection variables, and move it to its own section in `docs/INSTALL-CMAKE.md`. Ref: #17032 (Discussion) - tidy up descriptions/comments, alpha-sort. - move comment to its own section in `docs/INSTALL-CMAKE.md`. - split `HAVE_SSL_SET_QUIC_USE_LEGACY_CODEPOINT` to distinct names for each TLS backend API. To make the names more stable and to sync them with autotools. Follow-up to 07cc50f #17018 Follow-up to 342a654 #15873 - drop redundant condition while detecting QUICTLS API. Follow-up to 07cc50f #17018 - add config-comparison exception for `HAVE_SSL_SET_QUIC_TLS_CBS`. Follow-up to 5eefdd7 #17027 - detect `wolfSSL_get_peer_certificate` like autotools does. - detect `wolfSSL_UseALPN` like autotools does. Closes #17082
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
``` curl 8.13.1-DEV (Darwin) libcurl/8.13.1-DEV OpenSSL/3.5.0 [...] ngtcp2/1.12.90 nghttp3/1.9.0 Release-Date: [unreleased] Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets zstd ``` Ref: curl#17027 Closes curl#17018
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
With the new addition of OpenSSL QUIC API support and the support in ngtcp2 main branch, make the necessary adjustments in curl to support this combination. - add support in configure.ac to detect the feature OPENSSL_QUIC_API2 in openssl - initialise ngtcp2 properly in this combination - add a Curl_vquic_init() for global initialisation that ngtcp2 likes for performance reasons - add documentation on how to build in docs/HTTP3.md - add CI testing in http3-linux.yml Assisted-by: Viktor Szakats Closes curl#17027
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
- update text on dependency feature detection variables, and move it to its own section in `docs/INSTALL-CMAKE.md`. Ref: curl#17032 (Discussion) - tidy up descriptions/comments, alpha-sort. - move comment to its own section in `docs/INSTALL-CMAKE.md`. - split `HAVE_SSL_SET_QUIC_USE_LEGACY_CODEPOINT` to distinct names for each TLS backend API. To make the names more stable and to sync them with autotools. Follow-up to 07cc50f curl#17018 Follow-up to 342a654 curl#15873 - drop redundant condition while detecting QUICTLS API. Follow-up to 07cc50f curl#17018 - add config-comparison exception for `HAVE_SSL_SET_QUIC_TLS_CBS`. Follow-up to 5eefdd7 curl#17027 - detect `wolfSSL_get_peer_certificate` like autotools does. - detect `wolfSSL_UseALPN` like autotools does. Closes curl#17082
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
``` curl 8.13.1-DEV (Darwin) libcurl/8.13.1-DEV OpenSSL/3.5.0 [...] ngtcp2/1.12.90 nghttp3/1.9.0 Release-Date: [unreleased] Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets zstd ``` Ref: curl#17027 Closes curl#17018
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
With the new addition of OpenSSL QUIC API support and the support in ngtcp2 main branch, make the necessary adjustments in curl to support this combination. - add support in configure.ac to detect the feature OPENSSL_QUIC_API2 in openssl - initialise ngtcp2 properly in this combination - add a Curl_vquic_init() for global initialisation that ngtcp2 likes for performance reasons - add documentation on how to build in docs/HTTP3.md - add CI testing in http3-linux.yml Assisted-by: Viktor Szakats Closes curl#17027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new addition of QUIC support and the support in ngtcp2 main branch, make the necessary adjustments in curl to support this combination.
configure.acto detect the featureOPENSSL_QUIC_API2in opensslCurl_vquic_init()for global initialisation that ngtcp2 likes for performance reasonsMissing: