wcurl: import v2025.02.24 script + docs #17035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #17035 at 23d2ae2a: Test 303 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks @vszakats. How about installing the script on make install? With this PR, the autotools version installs it in $prefix/bin but I'm struggling to figure out how this should be done in cmake. |
This comment was marked as resolved.
This comment was marked as resolved.
samueloph
reviewed
Apr 15, 2025
vszakats
reviewed
Apr 15, 2025
bagder
added a commit
that referenced
this pull request
Apr 16, 2025
Build/install the man page. Install the script. This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible. wcurl development, issues etc is still to be done at https://github.com/curl/wcurl The imported wcurl man page is not from v2025.02.24 as the markdown version was fixed after that release. Assisted-by: Viktor Szakats Closes #17035
vszakats
added a commit
that referenced
this pull request
Apr 16, 2025
To sync with autotools builds. Reported-by: Daniel Stenberg Bug: #17035 (review) Follow-up to 5023ffa #13197 Closes #17068
bagder
added a commit
that referenced
this pull request
Apr 18, 2025
Build/install the man page. Install the script. This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible. wcurl development, issues etc is still to be done at https://github.com/curl/wcurl The imported wcurl man page is not from v2025.02.24 as the markdown version was fixed after that release. Assisted-by: Viktor Szakats Closes #17035
|
Maybe I should exclude the imported wcurl documentation from all docs checks... |
This should address all the findings: |
Build/install the man page. Install the script. This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible. wcurl development, issues etc is still to be done at https://github.com/curl/wcurl The imported wcurl man page is not from v2025.02.24 as the markdown version was fixed after that release. Assisted-by: Viktor Szakats Closes #17035
|
Test 1140 failing with: |
|
I will push a new rev with those fixes soon. |
|
#17111 confirmed that the latest changes I pushed to the wcurl repo fixes these CI failures. |
|
Thanks @samueloph, some of those complaints could probably be considered room for improvements of the cd2nroff script. |
|
@bagder indeed, I might be able to play with it during my vacation next month. This PR has an outdated wcurl script I believe, we've also updated the script's help output and comments, but they all passed the CI in the draft PR so everything should be fine now. Can I do a new release of wcurl now? Then you pull from it? |
Absolutely, then I can sync this PR with that. |
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To sync with autotools builds. Reported-by: Daniel Stenberg Bug: curl#17035 (review) Follow-up to 5023ffa curl#13197 Closes curl#17068
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Build/install the man page. Install the script. This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible. wcurl development, issues etc is still to be done at https://github.com/curl/wcurl Assisted-by: Viktor Szakats Assisted-by: Samuel Henrique Closes curl#17035
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To sync with autotools builds. Reported-by: Daniel Stenberg Bug: curl#17035 (review) Follow-up to 5023ffa curl#13197 Closes curl#17068
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Build/install the man page. Install the script. This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible. wcurl development, issues etc is still to be done at https://github.com/curl/wcurl Assisted-by: Viktor Szakats Assisted-by: Samuel Henrique Closes curl#17035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build/install the man page. Install the script.
This an "import" rather than just adding the script into the release tarball with maketgz to make sure the tarball build is completely reproducible.
wcurl development, issues etc is still to be done at https://github.com/curl/wcurl