curl_get_line: handle lines ending on the buffer boundary

[cole-h]

Very similar to 9f8bdd0, but affects e.g. netrc file parsing.

Suggested-by: Graham Christensen graham@grahamc.com

---

I opted to write a Perl test for this, since I didn't know how dynamic the %HOSTIP is, and triggering this bug requires the netrc line to be exactly 127 characters (so if it changes away from 127.0.0.1 in the future, this test would start to fail).

I am very far from an experienced Perl author, but I didn't see any examples of command type="shell" in the repo, so I just adapted an existing Perl test runner thing.

[cole-h]

Running make test on the box where I developed this patch gave me:

TESTDONE: 1800 tests were considered during 410 seconds.
TESTDONE: 1615 tests out of 1615 reported OK: 100%

Not sure why it's failing in CI, but I'd be glad to fix that up if you can provide any tips on how to do so!

[testclutch]

Analysis of PR #17036 at 6b3c929f:

Test 744 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2033 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

[dfandrich]

It doesn't look to me like you need a helper perl script to test this. Write the netrc file with a /testcase/client/file section (I'm giving XPath style there) like in test130. You can use %repeat[100 x a]% to pad the file to an exact length, although it would need to be precalculated (see test2080 for an example). Use a /testcase/client/precheck section like test1082 to ensure the address is what you expect. Then use a regular /testcase/client/command section similar to test130 again to actually run the curl command.

[bagder]

If you use a proxy for the test, you can use a netrc file with a fixed size since the hostname is not going to change.

The netrc file can be provided with a 127 byte line like done in the new test 743 added in 9f8bdd0

[cole-h]

Thanks for the suggestions, both!

I went with @bagder's suggestion in the end, and it is indeed much nicer than making a Perl helper 😆

TESTDONE: 1800 tests were considered during 544 seconds.
TESTDONE: 1561 tests out of 1561 reported OK: 100%

[bagder]

Thanks!