processhelp.pm: always call taskkill with -f (force)
#17054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
taskkill with -ftaskkill with -f (force)
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
In the hope this avoid a possible hang in `taskkill`. To kill processes, `runtests` first tries to kill them gently (with "TERM", or on Windows `taskkill`), then waits some time for them to disappear and then kills them with `KILL`, or on Windows with `taskkill -f`. This happens within `killpid()`. This patch bumps the gentle phase to `taskkill -f`. On the obervation that a non-forced `taskkill` may hang in cases: msvc, CM x64-windows wolfssl +examples: ``` [...] test 3006...[SMTP with multiple invalid (all) --mail-rcpt and --mail-rcpt-allowfails] --p----e--- OK (1682 out of 1718, remaining: 00:04, took 0.524s, duration: 03:13) test 3005...[SMTP with multiple and invalid (all but one) --mail-rcpt and --mail-rcpt-allowfails] --p-u--e-Executing: 'taskkill -t -pid 1196 >nul 2>&1' ``` Ref: https://github.com/curl/curl/actions/runs/14445993473/job/40508986059?pr=17051#step:15:4176 Cancelling the job worked, resulting in a greyed out status, with the above step and log entries lost. If this change causes issues or does nothing at all, we may revert it or limit it to CI runs. Ref: curl#14854 Closes curl#17054
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
In the hope this avoid a possible hang in `taskkill`. To kill processes, `runtests` first tries to kill them gently (with "TERM", or on Windows `taskkill`), then waits some time for them to disappear and then kills them with `KILL`, or on Windows with `taskkill -f`. This happens within `killpid()`. This patch bumps the gentle phase to `taskkill -f`. On the obervation that a non-forced `taskkill` may hang in cases: msvc, CM x64-windows wolfssl +examples: ``` [...] test 3006...[SMTP with multiple invalid (all) --mail-rcpt and --mail-rcpt-allowfails] --p----e--- OK (1682 out of 1718, remaining: 00:04, took 0.524s, duration: 03:13) test 3005...[SMTP with multiple and invalid (all but one) --mail-rcpt and --mail-rcpt-allowfails] --p-u--e-Executing: 'taskkill -t -pid 1196 >nul 2>&1' ``` Ref: https://github.com/curl/curl/actions/runs/14445993473/job/40508986059?pr=17051#step:15:4176 Cancelling the job worked, resulting in a greyed out status, with the above step and log entries lost. If this change causes issues or does nothing at all, we may revert it or limit it to CI runs. Ref: curl#14854 Closes curl#17054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hope this avoid a possible hang in
taskkill.To kill processes,
runtestsfirst tries to kill them gently (with"TERM", or on Windows
taskkill), then waits some time for themto disappear and then kills them with
KILL, or on Windows withtaskkill -f. This happens withinkillpid().This patch bumps the gentle phase to
taskkill -f. On the obervationthat a non-forced
taskkillmay hang in cases:msvc, CM x64-windows wolfssl +examples:
Ref: https://github.com/curl/curl/actions/runs/14445993473/job/40508986059?pr=17051#step:15:4176
Cancelling the job worked, resulting in a greyed out status, with the above
step and log entries lost.
If this change causes issues or does nothing at all, we may revert it
or limit it to CI runs.
Ref: #14854 (comment)