cmake: append picky warnings to CMAKE_REQUIRED_FLAGS as string
#17055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMAKE_REQUIRED_FLAGS` is already space-separated https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html
vszakats
force-pushed
the
cm-req-flag-fixup
branch
from
1ae59c5 to
d5f50af
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Also: - drop unnecessary type conversion. `CMAKE_REQUIRED_FLAGS` is already space-separated. https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html Follow-up to e865420 curl#17047 Closes curl#17055
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Also: - drop unnecessary type conversion. `CMAKE_REQUIRED_FLAGS` is already space-separated. https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html Follow-up to e865420 curl#17047 Closes curl#17055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
CMAKE_REQUIRED_FLAGSis alreadyspace-separated.
https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html
Follow-up to e865420 #17047