cmake: merge CURL_WERROR logic into PickyWarnings.cmake
#17062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe to do this now, as the code no longer relies on setting these options after feature detection. Follow-up to e865420 curl#17047
- replace hack with -pedantic-errors - display WERROR options in log
vszakats
changed the title
CURL_WERROR logic to PickyWarnings.cmakeCURL_WERROR logic into PickyWarnings.cmake
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Safe to do this now, as the code no longer relies on setting these options after feature detection. Also: Tidy up the way we handle options not to be passed to feature checks, and make sure to show them in the configure log. Follow-up to e865420 curl#17047 Closes curl#17062
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Safe to do this now, as the code no longer relies on setting these options after feature detection. Also: Tidy up the way we handle options not to be passed to feature checks, and make sure to show them in the configure log. Follow-up to e865420 curl#17047 Closes curl#17062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe to do this now, as the code no longer relies on setting these
options after feature detection.
Also: Tidy up the way we handle options not to be passed to feature
checks, and make sure to show them in the configure log.
Follow-up to e865420 #17047