cmake: tidy up and document feature detections in dependencies #17082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
vszakats
force-pushed
the
quictlsapi-tidy
branch
from
49eefba to
d4fc217
Compare
vszakats
changed the title
vszakats
changed the title
vszakats
changed the title
vszakats
force-pushed
the
quictlsapi-tidy
branch
2 times, most recently
from
12968c7 to
e17bdb3
Compare
Also tidy up descriptions/comments TODO: move to docs/INSTALL-CMAKE.md?
vszakats
force-pushed
the
quictlsapi-tidy
branch
from
95b5cab to
93bfedc
Compare
vszakats
changed the title
vszakats
changed the title
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 24, 2025
Cherry-picked from curl#17082
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Apr 24, 2025
vszakats
added a commit
that referenced
this pull request
Apr 24, 2025
Sync them with the function name they detect, and sync them between cmake and autotools. - rename `HAVE_WOLFSSL_BIO` to `HAVE_WOLFSSL_BIO_NEW`. - rename `HAVE_WOLFSSL_FULL_BIO` to `HAVE_WOLFSSL_BIO_SET_SHUTDOWN`. - autotools: rename `WOLFSSL_NTLM` to `HAVE_WOLFSSL_DES_ECB_ENCRYPT` (to sync with cmake). - autotools: rename `WOLFSSL_BIO` to `HAVE_WOLFSSL_BIO_NEW` (to sync with cmake). - autotools: simplify `HAVE_WOLFSSL_DES_ECB_ENCRYPT` detection. Cherry-picked from #17082 Closes #17175
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
- update text on dependency feature detection variables, and move it to its own section in `docs/INSTALL-CMAKE.md`. Ref: curl#17032 (Discussion) - tidy up descriptions/comments, alpha-sort. - move comment to its own section in `docs/INSTALL-CMAKE.md`. - split `HAVE_SSL_SET_QUIC_USE_LEGACY_CODEPOINT` to distinct names for each TLS backend API. To make the names more stable and to sync them with autotools. Follow-up to 07cc50f curl#17018 Follow-up to 342a654 curl#15873 - drop redundant condition while detecting QUICTLS API. Follow-up to 07cc50f curl#17018 - add config-comparison exception for `HAVE_SSL_SET_QUIC_TLS_CBS`. Follow-up to 5eefdd7 curl#17027 - detect `wolfSSL_get_peer_certificate` like autotools does. - detect `wolfSSL_UseALPN` like autotools does. Closes curl#17082
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Cherry-picked from curl#17082 Closes curl#17172
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Sync them with the function name they detect, and sync them between cmake and autotools. - rename `HAVE_WOLFSSL_BIO` to `HAVE_WOLFSSL_BIO_NEW`. - rename `HAVE_WOLFSSL_FULL_BIO` to `HAVE_WOLFSSL_BIO_SET_SHUTDOWN`. - autotools: rename `WOLFSSL_NTLM` to `HAVE_WOLFSSL_DES_ECB_ENCRYPT` (to sync with cmake). - autotools: rename `WOLFSSL_BIO` to `HAVE_WOLFSSL_BIO_NEW` (to sync with cmake). - autotools: simplify `HAVE_WOLFSSL_DES_ECB_ENCRYPT` detection. Cherry-picked from curl#17082 Closes curl#17175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update text on dependency feature detection variables, and move it
to its own section in
docs/INSTALL-CMAKE.md.Ref: Curl uses find_package when using an SSL backend which requires you to have prebuilt binaries. #17032 (Discussion)
tidy up descriptions/comments, alpha-sort.
move comment to its own section in
docs/INSTALL-CMAKE.md.split
HAVE_SSL_SET_QUIC_USE_LEGACY_CODEPOINTto distinct names foreach TLS backend API. To make the names more stable and to sync them
with autotools.
Follow-up to 07cc50f cmake: add openssl 3.5.0 + ngtcp2 support #17018
Follow-up to 342a654 cmake: sync OpenSSL QUIC fork detection with autotools #15873
drop redundant condition while detecting QUICTLS API.
Follow-up to 07cc50f cmake: add openssl 3.5.0 + ngtcp2 support #17018
add config-comparison exception for
HAVE_SSL_SET_QUIC_TLS_CBS.Follow-up to 5eefdd7 ngtcp2+openssl support #17027
detect
wolfSSL_get_peer_certificatelike autotools does.detect
wolfSSL_UseALPNlike autotools does.w/o ws https://github.com/curl/curl/pull/17082/files?w=1
wolfSSL_UseALPNfeature check?HAVE_ALPNseems to be sufficient for this, and the detection result isn't used during configuration.wolfSSL_set_quic_use_legacy_codelike cmake does #17172 build: tidy up internal feature detection variables for wolfSSL #17175