Skip to content

doh: reduce the DNS request buffer size #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 17, 2025

No point in having it larger than the largest allowed request size.

Also removed a no longer used struct.

No point in having it larger than the largest allowed request size.

Also removed a no longer used struct.
@github-actions github-actions bot added the name lookup DNS and related tech label Apr 17, 2025
@testclutch
Copy link

Analysis of PR #17087 at b6673378:

Test 1235 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1243 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1248 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 834836d Apr 18, 2025
@bagder bagder deleted the bagder/smaller-doh branch April 18, 2025 21:11
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
No point in having it larger than the largest allowed request size.

Also removed a no longer used struct.

Closes curl#17087
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
No point in having it larger than the largest allowed request size.

Also removed a no longer used struct.

Closes curl#17087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name lookup DNS and related tech
Development

Successfully merging this pull request may close these issues.

2 participants