openssl-quic: avoid potential -Wnull-dereference, add assert
#17107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen while building curl-for-win with OpenSSL QUIC.
Silences:
```
In file included from _x86-win-ucrt-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_5_c.c:55:
In function 'cf_osslq_check_and_unblock',
inlined from 'cf_progress_egress' at lib/vquic/curl_osslq.c:1730:12:
lib/vquic/curl_osslq.c:1581:11: error: potential null pointer dereference [-Werror=null-dereference]
1581 | nghttp3_conn_unblock_stream(ctx->h3.conn, stream->s.id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/vquic/curl_osslq.c:1582:34: error: potential null pointer dereference [-Werror=null-dereference]
1582 | stream->s.send_blocked = FALSE;
| ^
```
bagder
reviewed
Apr 20, 2025
vszakats
changed the title
-Wnull-dereference
Co-authored-by: Daniel Stenberg <daniel@haxx.se>
vszakats
changed the title
-Wnull-dereference-Wnull-dereference, add assert
bagder
approved these changes
Apr 22, 2025
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Seen with curl-for-win, OpenSSL QUIC, gcc 14.2.0, cmake unity mode.
Silences:
```
In file included from _x86-win-ucrt-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_5_c.c:55:
In function 'cf_osslq_check_and_unblock',
inlined from 'cf_progress_egress' at lib/vquic/curl_osslq.c:1730:12:
lib/vquic/curl_osslq.c:1581:11: error: potential null pointer dereference [-Werror=null-dereference]
1581 | nghttp3_conn_unblock_stream(ctx->h3.conn, stream->s.id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/vquic/curl_osslq.c:1582:34: error: potential null pointer dereference [-Werror=null-dereference]
1582 | stream->s.send_blocked = FALSE;
| ^
```
Co-authored-by: Daniel Stenberg
Co-authored-by: Stefan Eissing
Closes curl#17107
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Seen with curl-for-win, OpenSSL QUIC, gcc 14.2.0, cmake unity mode.
Silences:
```
In file included from _x86-win-ucrt-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_5_c.c:55:
In function 'cf_osslq_check_and_unblock',
inlined from 'cf_progress_egress' at lib/vquic/curl_osslq.c:1730:12:
lib/vquic/curl_osslq.c:1581:11: error: potential null pointer dereference [-Werror=null-dereference]
1581 | nghttp3_conn_unblock_stream(ctx->h3.conn, stream->s.id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/vquic/curl_osslq.c:1582:34: error: potential null pointer dereference [-Werror=null-dereference]
1582 | stream->s.send_blocked = FALSE;
| ^
```
Co-authored-by: Daniel Stenberg
Co-authored-by: Stefan Eissing
Closes curl#17107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen with curl-for-win, OpenSSL QUIC, gcc 14.2.0, cmake unity mode.
Silences: