typecheck improvements #17143
Closed
typecheck improvements #17143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/typecheck
branch
from
5f902eb to
e2c89c0
Compare
|
Analysis of PR #17143 at 0d9ceeb4: Test 745 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 264 different CI jobs (the link just goes to one of them). Generated by Testclutch |
Refreshed, cleaned up, improved and now checks *all* options. This must have stopped working at some point. gcc-14 least shows these warnings with this change, not without. Add test 745 to verify that all options listed in curl.h is also checked by the typechecker. This improved checker found almost 30 mistakes in the curl git repository. Closes #17143
bagder
force-pushed
the
bagder/typecheck
branch
from
aebf611 to
6327dff
Compare
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Refreshed, cleaned up, improved and now checks *all* options. This must have stopped working at some point. gcc-14 least shows these warnings with this change, not without. Add test 745 to verify that all options listed in curl.h is also checked by the typechecker. This improved checker found almost 30 mistakes in the curl git repository. Closes curl#17143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major refresh and cleanup
This adds test 745 that verifies that each option listed in
curl.hhas a corresponding typecheck.