ws: store protocol context as connection meta data #17146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates union member on struct connectdata. Sample of how other procotols can handle their connection related data. This avoids potention mix-ups of the `proto` union of a connection with other protocol instances. Removed ws "disconnect" callback as meta data is automatically destroyed when a connection is destroyed.
|
@bagder this is an idea which, if deemed good, could replace all those union members. We could, for memory foot print, make a |
bagder
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates union member on struct connectdata. Sample of how other procotols can handle their connection related data.
This avoids potential mix-ups of the
protounion of a connection with other protocol instances.Removed ws "disconnect" callback as meta data is automatically destroyed when a connection is destroyed.