cmake: stop deleting -W<n> from CMAKE_C_FLAGS (MSVC)
#17179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to e865420 curl#17047 Ref: 866e029 curl#1711
This reverts commit dc9ebb2.
vszakats
force-pushed
the
cm-avoid-touching-custom-cflags
branch
from
0a6536f to
b630976
Compare
vszakats
changed the title
CMAKE_C_FLAGS (MSVC)-W<n> from CMAKE_C_FLAGS (MSVC)
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
1. `CMAKE_C_FLAGS` may apply to other projects, and deleting/altering it may be unexpected. 2. We pass `-W4`/`-Wall` internally now, which do override custom `-W<n>` options in all supported MSVC versions. (as tested with Visual Studio generators) Ref: https://ci.appveyor.com/project/curlorg/curl/builds/51945416 Follow-up to e865420 curl#17047 Ref: 866e029 curl#1711 Closes curl#17179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_C_FLAGSmay apply to other projects, and deleting/altering itmay be unexpected.
We pass
-W4/-Wallinternally now, which do override custom-W<n>options in all supported MSVC versions.(as tested with Visual Studio generators)
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/51945416
Follow-up to e865420 #17047
Ref: 866e029 #1711