Skip to content

cmake: Threads detection update. ref: #1702 - #1719

Closed
snikulov wants to merge 1 commit into
curl:masterfrom
snikulov:cmake_pthread_test
Closed

snikulov wants to merge 1 commit into
curl:masterfrom
snikulov:cmake_pthread_test

Conversation

@snikulov

@snikulov snikulov commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

Some improvement for #1702.

  • make ENABLE_ARES and ENABLE_THREADED_RESOLVER (by default ENABLE_ARES will win if enabled)
  • enforce Threads package if ENABLE_THREADED_RESOLVER set to ON.
  • Variables will be set to ON according to CMake findings

@snikulov snikulov added the cmake label Aug 1, 2017
@mention-bot

Copy link
Copy Markdown

@snikulov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @ligfx to be potential reviewers.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 75.267% when pulling 0e93fab on snikulov:cmake_pthread_test into 0139545 on curl:master.

@bagder

bagder commented Aug 12, 2017

Copy link
Copy Markdown
Member

So what will the default resolver be if nothing is set by the user?

@snikulov

Copy link
Copy Markdown
Contributor Author

@bagder threaded.

@bagder bagder closed this in a905e88 Aug 13, 2017
@bagder

bagder commented Aug 13, 2017

Copy link
Copy Markdown
Member

Thanks!

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants