/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Threads detection update. ref: #1702 #1719

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@snikulov @mention-bot @coveralls @bagder
@snikulov
Member

snikulov commented Aug 1, 2017

Some improvement for #1702.

  • make ENABLE_ARES and ENABLE_THREADED_RESOLVER (by default ENABLE_ARES will win if enabled)
  • enforce Threads package if ENABLE_THREADED_RESOLVER set to ON.
  • Variables will be set to ON according to CMake findings

@snikulov snikulov added the cmake label Aug 1, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 1, 2017

@snikulov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @ligfx to be potential reviewers.

mention-bot commented Aug 1, 2017

@snikulov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @ligfx to be potential reviewers.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 1, 2017

Coverage Status

Coverage remained the same at 75.267% when pulling 0e93fab on snikulov:cmake_pthread_test into 0139545 on curl:master.

coveralls commented Aug 1, 2017

Coverage Status

Coverage remained the same at 75.267% when pulling 0e93fab on snikulov:cmake_pthread_test into 0139545 on curl:master.
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 12, 2017

Member

So what will the default resolver be if nothing is set by the user?
Member

bagder commented Aug 12, 2017

So what will the default resolver be if nothing is set by the user?
@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Aug 13, 2017

Member

@bagder threaded.
Member

snikulov commented Aug 13, 2017

@bagder threaded.

@bagder bagder closed this in a905e88 Aug 13, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 13, 2017

Member

Thanks!
Member

bagder commented Aug 13, 2017

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment