Skip to content

cfilters: remove assert #17211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cfilters: remove assert #17211

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 28, 2025

The OSS-fuzz probe reaches this, so it can apparently in run-time. There is already a run-time handling of the situation.

@bagder
cfilters: remove assert
2721809 
The OSS-fuzz probe reaches this, so it can apparently in run-time. There
is already a run-time handling of the situation.
@bagder bagder requested a review from icing April 28, 2025 15:06
@bagder bagder marked this pull request as ready for review April 28, 2025 15:08
icing
icing reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@icing icing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that. From the stack trace it seems that FTP is in a weird state. But it's hard to see how it got there.

@bagder
Copy link
Member Author

bagder commented Apr 28, 2025

But it's hard to see how it got there.

Indeed. It looks like this situation should have been detected as a problem earlier than this.

@bagder bagder closed this in da33c1e Apr 28, 2025
@bagder bagder deleted the bagder/cfilters-assert branch April 28, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icing icing icing left review comments

Assignees
No one assigned
Labels
connecting & proxies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagder @icing