spacecheck.pl: check for non-ASCII chars, fix fallouts #17247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedayak
reviewed
May 3, 2025
| string(REGEX REPLACE "\\\\\n" "!π!α!" _makefile_inc_text ${_makefile_inc_text}) | ||
| string(REGEX REPLACE "\\\\\n" "!^!^!" _makefile_inc_text ${_makefile_inc_text}) |
There was a problem hiding this comment.
What is this used for? Is there a significance for the characters?
There was a problem hiding this comment.
I think the idea is to use something that cannot occur in the original
Makefile.inc, nor in the generated Makefile.inc.cmake. Anything
fitting that would do. Using Unicode here was perhaps overkill.
Perhaps !^!^! still is!
Another option is to strip the newlines without reinserting them after
transformation. With the slight downside of making these interim files
less human-readable due to the long lines (libssh2 does it like that):
string(REGEX REPLACE "\\\\\n" "" _makefile_inc_text ${_makefile_inc_text})
string(REGEX REPLACE "([a-zA-Z_][a-zA-Z0-9_]*)[\t ]*=[\t ]*([^\n]*)" "set(\\1 \\2)" _makefile_inc_text ${_makefile_inc_text})Suggested by Dan
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
May 12, 2025
Exclude test data files (4 of them) based on existing feature tags: `codeset-utf8` and `Unicode`. Add a new feature 'codeset-non-ascii' to mark remaining exceptions (9 files). Follow-up to 838dc53 curl#17247
vszakats
added a commit
that referenced
this pull request
May 13, 2025
- replace ß (scharfes S) with links.
- replace § (section sign) with links.
- replace 🙏 emoji with `:pray:`.
Supported by GitHub, Forgejo/Gitea and most likely GitLab.
- docs/libcurl/curl_mprintf.md: replace Unicode ± with `{+|-}`.
- docs/CIPHERS.md: URL encode Unicode in URLs.
- lib1560: use hex encoding in `räksmörgås.se`.
- unit1307: use hex encoding in `Lindmätarv`.
- drop LATIN SMALL LETTER A WITH ACUTE exception.
No longer appears in tests.
This leaves the single character exception: `ö`
And file exceptions holding contributor names.
Follow-up to 9243ed5 #17329
Follow-up to 838dc53 #17247
Closes #17335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: James Fuller
Assisted-by: Dan Fandrich