tests: separate tunit tests from unit tests more #17259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tunit tests need no unittest libcurl version - unit tests need no tool code - unit test 1621 is now tunit test 1621 instead - build unit tests with BUILDING_LIBCURL as they pretent to be libcurl
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
May 6, 2025
To avoid adding this macro to the global `CURL_DEBUG_MACROS` variable, which may be used for targets defined after unit tests, and where this macro may not be necessary. At the moment unit tests are defined last, so this did not cause any issue. Follow-up to 220eda3 curl#17259
vszakats
added a commit
that referenced
this pull request
May 7, 2025
To avoid adding this macro to the global `CURL_DEBUG_MACROS` variable, which may be used for targets defined after unit tests, and where this macro may not be necessary. As of this commit unit tests are defined last, so extending the global variable did not cause any issue. Follow-up to 220eda3 #17259 Closes #17264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tunit tests need no unittest libcurl version