Skip to content

generate.bat: exclude curlinfo.c from legacy VS projects #17263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented May 6, 2025

  • Do not include curlinfo.c as a ClCompile unit when compiling the curl tool.

Prior to this change generate.bat would add curlinfo.c to the source files for the curl tool because it is located in the src directory. That caused ambiguous behavior in legacy versions of Visual Studio which had to guess between two main entry points (one in curlinfo and one in tool_main, the latter being correct).

Closes #xxxx

- Do not include curlinfo.c as a ClCompile unit when compiling the curl
  tool.

Prior to this change generate.bat would add curlinfo.c to the source
files for the curl tool because it is located in the src directory. That
caused ambiguous behavior in legacy versions of Visual Studio which had
to guess between two main entry points (one in curlinfo and one in
tool_main, the latter being correct).

Closes #xxxx
@jay jay added the Windows Windows-specific label May 6, 2025
@github-actions github-actions bot added the build label May 6, 2025
@jay jay mentioned this pull request May 6, 2025
8 tasks
@jay jay closed this in e3802ab May 7, 2025
@jay jay deleted the no_curlinfo_for_legacy branch May 7, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants