Skip to content

netrc: avoid NULL deref on weird input #17275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented May 7, 2025

A dynbuf that never gets populated might return a NULL, and Coverity could find a way through like that.

A dynbuf that never gets populated might return a NULL, and Coverity
could find a way through like that.
@bagder bagder marked this pull request as ready for review May 7, 2025 14:50
@bagder bagder closed this in 613436d May 7, 2025
@bagder bagder deleted the bagder/netrc-deref branch May 7, 2025 15:16
@testclutch
Copy link

Analysis of PR #17275 at 2fa8a076:

Test 1192 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test 1199 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1917 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 3017 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 564 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 700 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 3 different CI jobs (the link just goes to one of them).

Test 701 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 3 different CI jobs (the link just goes to one of them).

There are more failures, but that's enough from Gha.

Generated by Testclutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants